Use age's plugin.NewTerminalUI() instead of vendoring the code #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
commented
Jan 11, 2026
| return "", err | ||
| } | ||
| return string(passphrase), nil | ||
| return pluginTerminalUI.RequestValue("", fmt.Sprintf("Enter passphrase for identity '%s':", location), true) |
Contributor
Author
There was a problem hiding this comment.
If an error happens during reading, a slightly strange warning will be printed refering to an age plugin age-plugin-. The empty string is what is put after the last -. I'm not sure whether we should put something in there to make the warning a little bit less awkward.
Ref: FiloSottile/age@7f49d02#diff-a641cf812f55a9ba2325124414c15bbc493d4387a1a315ce3a16be0a7b9f6fdcR25
| } | ||
| passphrasePrompt := func() ([]byte, error) { | ||
| pass, err := readSecret(fmt.Sprintf("Enter passphrase for %q:", keyPath)) | ||
| pass, err := pluginTerminalUI.RequestValue("", fmt.Sprintf("Enter passphrase for %q:", keyPath), true) |
Contributor
Author
|
CC @brianmcgee |
Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
age-term
branch
from
ce5cb9a to
52e95da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FiloSottile/age#591 has been closed with FiloSottile/age@7f49d02. Let's use that instead of vendoring the code (and having to maintain it).