Revert "Merge pull request #1697 from onjen/fix-1142"#2099
Merged
felixfontein merged 1 commit intogetsops:mainfrom Mar 17, 2026
Merged
Revert "Merge pull request #1697 from onjen/fix-1142"#2099felixfontein merged 1 commit intogetsops:mainfrom
felixfontein merged 1 commit intogetsops:mainfrom
Conversation
felixfontein
force-pushed
the
gcp
branch
2 times, most recently
from
515d0d0 to
d8f1feb
Compare
sabre1041
approved these changes
Mar 17, 2026
Contributor
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
LGTM. The features introduced by this changed caused unintended consequences for SOPS users that are not leveraging Project Quotas. A new discussion has been started to determine the appropriate path forward
Contributor
Author
|
@sabre1041 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #1697, since that PR had unintended side-effects (see #2088).
If there is no better PR to fix the issue soon, this is likely what will get merged.
Closes #2088.