Conversation
Signed-off-by: somaz <genius5711@gmail.com>
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1620.
sops publish --recursivestops at the first file that no destination rule matches, so every file the walk reaches after it is never published. With the layout from the issue,project/a/prod/parameters.ymlaborts the run andproject/b/base/credentials.enc.ymlis left out.In recursive mode such a file is now skipped with a message, the same way a file declined at the interactive prompt already is. Publishing a single file still fails as before.
configexportsErrNoMatchingDestinationso the publish command can tell this case apart; the error text is unchanged.Two misconfigurations used to hit the same error, and I did not want them to turn into a run that skips every file and exits 0, so they now return their own errors: a config with no destination rules at all, and a destination
path_regexthat does not compile (it was treated as a non-match, while creation rules already report it).Validation:
go test ./...passes on Go 1.26.1 and the changed packages pass on Go 1.25.8. Against a Vault 1.14.0 dev server with the directory layout from the issue, main publishes one of the two files and exits 1, and this branch publishes both and exits 0.