Do the filtering before building task trees for the UI #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a FilteredTaskTreeManager class that prefilters the tasks before building a tree. Partially fixes GitHub issue getting-things-gnome#1207
Fixes the rest of GitHub issue getting-things-gnome#1207
- fixing uses of TaskStore.tree_model in the main code - re-introducing TaskStore.tree_model since a plugin directly references it - avoid duplicated creation of ListStore instances - other small fixes
|
I rebased the branch to trigger the updated GHA workflow. |
|
LGTM! And yes, signals would be more in line with GTK and probably more error-proof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1207
The main idea is that the
TaskStoreprovides pre-filteredGtk.TreeListModelinstances using the newly introducedFilteredTaskTreeManagerclass. This class performs the filtering before building the tree, thus producing correctly indented tree models. TheFilteredTaskTreeManageralso helps track when the expander should appear in the UI.Sidenotes:
TaskStoreby relying on signals instead of direct calls to update the trees. But one step at a time. :)