Open
Conversation
❌ Linting failed with 1 error ❌Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. Please review the linting results below and make any necessary changes to your submission. Linting Results
Legend
|
Author
|
I wasn't aware of the arm64+amd64 requirement. If that's a hard requirement, then I think this won't be merged for now. This makes me wonder, though, are there plans to be able to have non-multi-arch apps in the store and just indicate compatibility through the UI? |
Collaborator
|
Hey @Knufle, thanks for submitting handbrake to the Umbrel App Store! 🔝 🍍 Right now arm64+amd64 images are a hard requirement. So far there are no plans to support amd64 only apps in the store. Will let you know once that changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Submission
jlesage/docker-handbrake
HandBrake
256x256 SVG icon
I only have this 512x512 PNG image. Would you guys have a proper way to convert it to SVG?
Gallery images
Community Store
I created this community store just to test the app, and it worked as expected. I'm gonna leave the link here in case someone wants an easy way to try it.
I have tested my app on: