Enable third-party app access to qBittorrent API#5299
Open
Conversation
Enable qBittorrent's reverse proxy support so it reads the real client IP from X-Forwarded-For and checks it against AuthSubnetWhitelist. This allows third-party apps (e.g. qRemote) to authenticate with qBittorrent natively while preserving the subnet whitelist for internal auto-configuration of Radarr, Sonarr, etc. Fixes #4315
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Forwarded-Forand checks it againstAuthSubnetWhitelistinstead of the direct connection IPPROXY_AUTH_WHITELIST: "/api/*"so third-party apps can reach the API without Umbrel's proxy authThis allows third-party apps (e.g. qRemote on iOS) to authenticate with qBittorrent natively while preserving the subnet whitelist for internal auto-configuration of Radarr, Sonarr, etc.
Fixes #4315
How it works
/api/*through, setsX-Forwarded-For: 192.168.1.x→ doesn't match10.21.0.0/16→ qBittorrent requires native loginPROXY_AUTH_ADDhandles it as usual@al-lac I've tested this on my Umbrel and confirmed all three scenarios work. No need to merge this PR directly, feel free to bring these changes into your existing qBittorrent PR if that's easier.