Skip to content

Add ZMQ publish option to Monero command, required for p2pool mining#5382

Open
brainchainz wants to merge 3 commits intogetumbrel:masterfrom
brainchainz:master
Open

Add ZMQ publish option to Monero command, required for p2pool mining#5382
brainchainz wants to merge 3 commits intogetumbrel:masterfrom
brainchainz:master

Conversation

@brainchainz
Copy link
Copy Markdown

This publishing is required for Monero nodes to connect with the P2pool decentralized mining protocol. Users currently have to add this in manually. Adding it here would make the mining experience seamless for non-technical users.

@github-actions
Copy link
Copy Markdown

⚠️   Linting finished with 1 warning   ⚠️

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ monero/docker-compose.yml Mounted file/directory "/monero/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/monero/torrc", but it is not present. This can lead to permission errors!
ℹ️ monero/docker-compose.yml External port mapping "${APP_MONERO_P2P_PORT}:${APP_MONERO_P2P_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ monero/docker-compose.yml External port mapping "${APP_MONERO_RPC_PORT}:${APP_MONERO_RPC_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ monero/docker-compose.yml Potentially using unsafe user in service "server":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
⚠️ monero/docker-compose.yml Invalid restart policy:
The restart policy of the container "monerod" should be set to "on-failure".

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant