Skip to content

Bitcoin Knots: update I2P to v2.59 and rebase the warper on the latest upstream changes#5383

Open
Retropex wants to merge 1 commit intogetumbrel:masterfrom
Retropex:I2P+rebasecore
Open

Bitcoin Knots: update I2P to v2.59 and rebase the warper on the latest upstream changes#5383
Retropex wants to merge 1 commit intogetumbrel:masterfrom
Retropex:I2P+rebasecore

Conversation

@Retropex
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ bitcoin-knots/docker-compose.yml Mounted file/directory "/bitcoin-knots/torrc" doesn't exist:
The volume "${APP_DATA_DIR}/torrc:/etc/tor/torrc:ro" tries to mount the file/directory "/bitcoin-knots/torrc", but it is not present. This can lead to permission errors!
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_P2P_PORT}:${APP_BITCOIN_KNOTS_P2P_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml External port mapping "${APP_BITCOIN_KNOTS_RPC_PORT}:${APP_BITCOIN_KNOTS_RPC_PORT}":
Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).
ℹ️ bitcoin-knots/docker-compose.yml Using unsafe user "root" in service "i2pd_daemon":
The user "root" can lead to security vulnerabilities. If possible please use a non-root user instead.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant