This repository was archived by the owner on Jun 23, 2023. It is now read-only.
Support Autofill Extensions for Password Inputs#367
Open
TannerR1776 wants to merge 1 commit intogetumbrel:masterfrom
Open
Support Autofill Extensions for Password Inputs#367TannerR1776 wants to merge 1 commit intogetumbrel:masterfrom
TannerR1776 wants to merge 1 commit intogetumbrel:masterfrom
Conversation
|
Are there any plans to merge this? It would be really nice to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is being opened to resolve issue #322.
The issue was that the password inputs had broken CSS and form grouping which caused LastPass (for example) to overlap with the show/hide button.
I have refactored the password-input component to properly group inputs. Additionally, I have refactored the styling of this component to try and make it more self contained. With the addition of the
displayStyleprop, the parent can now dictate a style preference without needing to know the implementation details required to properly style the child component.Please let me know if there is any feedback on these changes. This update has been tested locally in my environment in Chrome and FireFox.
Here is what the refactored inputs look like now: