Indent shortcodes as much as their starting line #2787

ISSOtm · 2025-02-03T12:08:42Z

I have confirmed that this fixes http://eldred.fr/blog/backcompat/part4/#compat-or-changes (the issue causes a </li> to go missing, which becomes especially noticeable at the bottom of the page).

I haven't added any tests, because I'm not really sure as to how that'd be checked. Asserting the output stream of cmark after expanding shortcodes?

Sanity check:

Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

Have you created/updated the relevant documentation page(s)?

This fixes getzola#2527.

* feat: port zola release build to gh actions & support linux arm64 Signed-off-by: Henrik Gerdes <[email protected]> * fix: add buildx support for multi-arch docker images Signed-off-by: Henrik Gerdes <[email protected]> * fix: pin gh release action to sha & allow pre-releases Signed-off-by: Henrik Gerdes <[email protected]> * fix: use env in gh action for linux arm build Signed-off-by: Henrik Gerdes <[email protected]> * chore: switch to dtolnay/rust-toolchain action for rust setup Signed-off-by: Henrik Gerdes <[email protected]> * fix: windows archive step Signed-off-by: Henrik Gerdes <[email protected]> --------- Signed-off-by: Henrik Gerdes <[email protected]>

Signed-off-by: xixishidibei <[email protected]>

Having a crate depend on files outside of its directory breaks building Zola as a dependency using Nix

* Add pagination info to get_section * Add documentation for pagination information * Stick to section properties `paginated` attributes removed

…nt (getzola#2688) This adds semantic meaning to the footnotes organization and improves accessibility by aiding disabled users who rely on assistive devices such as screen readers which utilize semantic tags such as the footer element in order to navigate properly. The hr element is semantically defined as representing a paragraph-level thematic break. Now that the footnotes are descendants of the footer element, the hr element originally preceding the footnotes list is no longer necessary (footnotes are no longer paragraph-level content) and thus replaced. However, the footer element is given the class "footnotes" to allow for styling, so the following CSS could be used to provide a stylistically equivalent visible border separating the footnotes from the content if so desired: .footnotes { border-top: 2px groove gray; } Test snapshots are also updated to reflect the new footer elements.

* Add external links class option to Markdown configuration * Validate external links class * Rename external link test snapshots

…n-minify-html * feat: do not minify js when minify html * test: update tests

…zola#2745) * Add optional arg to serve for extra paths to watch for changes * Address feedback

* Add path annotation for codeblock * Doc * Rename path to name

With the colon joined to the url , clicking resulted in the wrong link

* Add ShortcodeInvocationCounter * Add nested shortcode parsing and rendering * Remove ShortcodeInvocationCounter from render context * Remove interior mutability in ShortcodeInvocationCounter * Rename Shortcode::flatten to render_inner_shortcodes

…plate (getzola#2581)

) * Add `--skip-external-links` CLI flag to `check` subcommand * Add a test for checks with external links skipped * Add a description of `--skip-external-links` flag

* build: update pulldown-cmark to 0.12.2 * feat: enable rendering of definition list pulldown-cmark markdown parser added support for definition lists in https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.12.0 Parsing of definition lists using zola is optional and can be enabled using configuration variable `definition_list = true` (default is false). Closes getzola#2718 * chore: update CHANGELOG

* Implement zola serve --store-html Fixes getzola#2377 * Apply maintainer suggestions * fix tests --------- Co-authored-by: Vincent Prouillet <[email protected]>

* Add `*.txt` files to the files loaded by `tera` * Add note to `robots.txt` docs about extending the file with a .txt file

Now the build command supports minification and you can run `zola build --minify` to get the minified result only at build time. Closes getzola#1924.

Signed-off-by: Henrik Gerdes <[email protected]>

@Keats

`insert_anchor_links` was a valid `config.toml` setting before [0.0.6] but was changed to a section option. [0.0.6]: https://github.com/getzola/zola/blob/master/CHANGELOG.md#006-2017-05-24 It was mentioned in the documentation for `config.toml` until 2021 (getzola#1477). In 2021, @Keats said that "`insert_anchor_links` could probably be a config option in `config.toml`": getzola#634 (comment) In the same thread, several other users requested this feature. @Artoria2e5 said: > These sort of settings become annoying to copy-paste when a site ends > up with many sections. @ctron said: > But even more annoying is that it seems I can't add > insert_anchor_links on the top section, but need to place it in every > section. > > I think having this as a default configuration for the site makes > total sense.

Co-authored-by: Gregory Soutade <[email protected]>

…ccount not rendered pages for pagers computation (getzola#2782) Co-authored-by: Gregory Soutade <[email protected]>

Signed-off-by: Henrik Gerdes <[email protected]>

Keats and others added 30 commits August 15, 2024 20:19

Next version

ce10aae

exclude paginated pages in sitemap (getzola#2555)

0098119

This fixes getzola#2527.

chore: add missing symbol (getzola#2641)

45c558d

Signed-off-by: xixishidibei <[email protected]>

remove square brackets

6798b6e

Allow treating a missing highlight language as error (getzola#2642)

ead17d0

Move sublime into config module (getzola#2580)

9119e9f

Having a crate depend on files outside of its directory breaks building Zola as a dependency using Nix

Add pagination info to sections (getzola#2653)

ad79860

* Add pagination info to get_section * Add documentation for pagination information * Stick to section properties `paginated` attributes removed

Handle file events emitted by Nova on macOS (getzola#2674)

2b5c3d0

Add external links class option to Markdown configuration (getzola#2717)

dded202

* Add external links class option to Markdown configuration * Validate external links class * Rename external link test snapshots

refactor: replace static with const for global constants (getzola#2729)

bc00064

feat: do not minify js when minify html

11edd7d

test: update tests

4452794

Merge pull request getzola#2732 from st1020/feat/do-not-minify-js-whe…

a586d95

…n-minify-html * feat: do not minify js when minify html * test: update tests

Add optional arg to serve for extra paths to watch for changes (get…

0a43f61

…zola#2745) * Add optional arg to serve for extra paths to watch for changes * Address feedback

Add path annotation for codeblock (getzola#2610)

a8d0ddf

* Add path annotation for codeblock * Doc * Rename path to name

Update changelog

048473a

feat: make urls clickable in github action logs (getzola#2754)

6b2cdd8

With the colon joined to the url , clicking resulted in the wrong link

Allow nested shortcodes (getzola#2748)

336533d

* Add ShortcodeInvocationCounter * Add nested shortcode parsing and rendering * Remove ShortcodeInvocationCounter from render context * Remove interior mutability in ShortcodeInvocationCounter * Rename Shortcode::flatten to render_inner_shortcodes

Fix continue-reading parsing with inline HTML, add summary-cutoff tem…

ed2e577

…plate (getzola#2581)

Add --skip-external-links CLI flag to check subcommand (getzola#2756

d8ac819

) * Add `--skip-external-links` CLI flag to `check` subcommand * Add a test for checks with external links skipped * Add a description of `--skip-external-links` flag

Implement zola serve --store-html (getzola#2750)

769ebc6

* Implement zola serve --store-html Fixes getzola#2377 * Apply maintainer suggestions * fix tests --------- Co-authored-by: Vincent Prouillet <[email protected]>

Update deps

9733135

Adds *.txt to the list of template files loaded by Tera (getzola#2769)

897d8f5

* Add `*.txt` files to the files loaded by `tera` * Add note to `robots.txt` docs about extending the file with a .txt file

Adds minify option to build command (getzola#2776)

3f9bd81

Now the build command supports minification and you can run `zola build --minify` to get the minified result only at build time. Closes getzola#1924.

feat (ci): jobs use native compile (getzola#2777)

6aca0ac

Signed-off-by: Henrik Gerdes <[email protected]>

Handle permalink with anchor (doesn't add trailing slash) (getzola#2779)

d7d7d95

Co-authored-by: Gregory Soutade <[email protected]>

soutade and others added 2 commits January 30, 2025 10:59

Fix test can_build_site_with_pagination_for_taxonomy() by taking in a…

d6ae6d8

…ccount not rendered pages for pagers computation (getzola#2782) Co-authored-by: Gregory Soutade <[email protected]>

fix (ci): remove version print task (getzola#2783)

e613aa8

Signed-off-by: Henrik Gerdes <[email protected]>

ISSOtm mentioned this pull request Feb 3, 2025

Multi-line shortcodes end lists too early #2618

Open

ISSOtm force-pushed the shortcode-indent branch from f96a936 to 4dce66c Compare February 3, 2025 12:11

Indent shortcodes as much as their starting line

c957ffa

ISSOtm force-pushed the shortcode-indent branch from 4dce66c to c957ffa Compare February 3, 2025 12:14

Keats force-pushed the next branch from e661fd8 to 8543c29 Compare February 14, 2025 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Indent shortcodes as much as their starting line #2787

Indent shortcodes as much as their starting line #2787

ISSOtm commented Feb 3, 2025

Indent shortcodes as much as their starting line #2787

Are you sure you want to change the base?

Indent shortcodes as much as their starting line #2787

Conversation

ISSOtm commented Feb 3, 2025

Code changes