Skip to content

feat: add zola version variable #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: next
Choose a base branch
from
Open

feat: add zola version variable #2793

wants to merge 34 commits into from

Conversation

extua
Copy link

@extua extua commented Feb 9, 2025

Simple PR to expose the Zola version number as a Tera variable. See issue #2749 outlining the feature request.

The only way to export the cargo version number from the top-level cargofile down to the workspace was to set

[workspace.package]
version = "0.19.2"

following the Rust reference doc example.
This means this version number also needs to be set here as well as at the top of the file.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

This change is a (small) new feature and I can update the documentation after it is merged.

Sorry, something went wrong.

Keats and others added 30 commits August 15, 2024 20:19
* feat: port zola release build to gh actions & support linux arm64

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>

* fix: add buildx support for multi-arch docker images

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>

* fix: pin gh release action to sha & allow pre-releases

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>

* fix: use env in gh action for linux arm build

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>

* chore: switch to dtolnay/rust-toolchain action for rust setup

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>

* fix: windows archive step

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>

---------

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
Signed-off-by: xixishidibei <xixishidibei@outlook.com>
Having a crate depend on files outside of its directory
breaks building Zola as a dependency using Nix
* Add pagination info to get_section

* Add documentation for pagination information

* Stick to section properties

`paginated` attributes removed
…nt (getzola#2688)

This adds semantic meaning to the footnotes organization and improves
accessibility by aiding disabled users who rely on assistive devices
such as screen readers which utilize semantic tags such as the footer
element in order to navigate properly.

The hr element is semantically defined as representing a paragraph-level
thematic break. Now that the footnotes are descendants of the footer
element, the hr element originally preceding the footnotes list is
no longer necessary (footnotes are no longer paragraph-level content)
and thus replaced. However, the footer element is given the class
"footnotes" to allow for styling, so the following CSS could be used to
provide a stylistically equivalent visible border separating the
footnotes from the content if so desired:

    .footnotes {
      border-top: 2px groove gray;
    }

Test snapshots are also updated to reflect the new footer elements.
* Add external links class option to Markdown configuration

* Validate external links class

* Rename external link test snapshots
…n-minify-html

* feat: do not minify js when minify html

* test: update tests
…zola#2745)

* Add optional arg to serve for extra paths to watch for changes

* Address feedback
* Add path annotation for codeblock

* Doc

* Rename path to name
With the colon joined to the url , clicking resulted in the wrong link
* Add ShortcodeInvocationCounter

* Add nested shortcode parsing and rendering

* Remove ShortcodeInvocationCounter from render context

* Remove interior mutability in ShortcodeInvocationCounter

* Rename Shortcode::flatten to render_inner_shortcodes
)

* Add `--skip-external-links` CLI flag to `check` subcommand

* Add a test for checks with external links skipped

* Add a description of `--skip-external-links` flag
* build: update pulldown-cmark to 0.12.2

* feat: enable rendering of definition list

pulldown-cmark markdown parser added support for definition lists in
https://github.com/pulldown-cmark/pulldown-cmark/releases/tag/v0.12.0

Parsing of definition lists using zola is optional and can be enabled
using configuration variable `definition_list = true` (default is
false).

Closes getzola#2718

* chore: update CHANGELOG
* Implement zola serve --store-html

Fixes getzola#2377

* Apply maintainer suggestions

* fix tests

---------

Co-authored-by: Vincent Prouillet <balthek@gmail.com>
* Add `*.txt` files to the files loaded by `tera`

* Add note to `robots.txt` docs about extending the file with a .txt file
Now the build command supports minification and you can run `zola build
--minify` to get the minified result only at build time. Closes getzola#1924.
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
`insert_anchor_links` was a valid `config.toml` setting before [0.0.6]
but was changed to a section option.

[0.0.6]: https://github.com/getzola/zola/blob/master/CHANGELOG.md#006-2017-05-24

It was mentioned in the documentation for `config.toml` until 2021
(getzola#1477).

In 2021, @Keats said that "`insert_anchor_links` could probably be a
config option in `config.toml`":
getzola#634 (comment)

In the same thread, several other users requested this feature.
@Artoria2e5 said:

> These sort of settings become annoying to copy-paste when a site ends
> up with many sections.

@ctron said:

> But even more annoying is that it seems I can't add
> insert_anchor_links on the top section, but need to place it in every
> section.
>
> I think having this as a default configuration for the site makes
> total sense.
Co-authored-by: Gregory Soutade <gregory.soutade@elsys-design.com>
soutade and others added 4 commits January 30, 2025 10:59
…ccount not rendered pages for pagers computation (getzola#2782)

Co-authored-by: Gregory Soutade <gregory.soutade@elsys-design.com>
Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
@extua extua changed the title feat: add zola version variable, fixes #2749 feat: add zola version variable Feb 9, 2025
@@ -56,6 +56,8 @@ indexing-ja = ["libs/indexing-ja"]

[workspace]
members = ["components/*"]
[workspace.package]
version = "0.19.2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way to avoid specifying it twice?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's possible to de-duplicate these within the root cargofile. Another option would be to set the version number as a const in the root package, and then import it into the workspace for components/content. I'm not sure how to do that though.

This comment was marked as off-topic.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid specifying the version twice, we could retrieve env!("CARGO_PKG_VERSION") in the cli, and pass it to Site::new() ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet