Better port 0 handling
#2848
Open
Better port 0 handling
#2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user chooses to use port 0, then the operating system will choose one of the available ports automatically. This is very useful in cases where you want to allow a `zola serve` for a broader user base which might already bind a subset of their ports and if you don't know which ones they might use. This feature was already supported by zola, however, the printed output just printed port 0 and didn't report which port the operating system actually chose. Example output of `zola serve -p 0` before the change ``` Web server is available at http://127.0.0.1:0 (bound to 127.0.0.1:0) ``` Example output of `zola serve -p 0` after the change ``` Web server is available at http://127.0.0.1:37327 (bound to 127.0.0.1:37327) ```
|
Can you do the PR on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user chooses to use port 0, then the operating system will choose one of the available ports automatically. This is very useful in cases where you want to allow a
zola servefor a broader user base which might already bind a subset of their ports and if you don't know which ones they might use.This feature was already supported by zola, however, the printed output just printed port 0 and didn't report which port the operating system actually chose.
Example output of
zola serve -p 0before the changeExample output of
zola serve -p 0after the changeIMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: