-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use giallo instead of syntect #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/config.toml
Outdated
|
|
||
| [markdown.highlighting] | ||
| theme = "github-dark" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config has changed to allow more options. Setting a theme (or 2 for light/dark dual theming) will enable highlighting.
|
Hello. I am wondering how this works with custom syntax. On my website I have a couple of articles with languages not supported natively, and I’m using separate syntax files. I’m wondering what the path for transferring those would be. |
|
Odin: https://github.com/DanielGavin/ols/blob/master/editors/vscode/syntaxes/odin.tmLanguage.json you should be able to download those in your site, add the paths to them in the config and it should work |
|
Nice work! Would it also be possible for the |
|
Also, is there still a way to generate the css for a given theme? |
That's not possible, you need a theme to match the actual grammar scopes to theme scopes in textmate and I'm not going to expose that in Zola. How do you style via CSS?
I'd say no, in theory only |
Yes, I've just pushed the updated docs if you want to have a look. I won't have the time to do migration guide today though but it's pretty easy in theory. |
Oh, didn't know that. I took a theme I liked and manually modified the colors in the css. I also see the docs now, thanks! |
Thanks for the links. Saves me the search effort later. I was mostly pointing out that it is a breaking change that needs addressing (if you don't intend to keep syntect behind as a fallback). Complete tangent question: Is it possible somehow to annotate inline elements with a language for coloring or not? In other words, something like |
I've updated the docs and changelog now so that should be clearer.
I don't think so? You can't put which language it is in an inline code. Maybe with shortcodes? |
This won't work until you have giallo checked out in a sibling folder to zola and after running
just generate-dump. If you try it on your site, make sure you include the default CSS for giallo:I'll replace the path when rust-onig is released and therefore giallo can be on crates.io. I'll also remove the submodules and update docs etc at that point.