Separate search index item collection and serialization. #3085
+132
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all search index styles manually gathered items which should be included from the Library. This lead to subtly different inclusion rules. For instance, the `elasticlunr` search index would include the sub-pages of redirect sections, while `fuse` did not. This patch centralizes the collection into a single routine which is used for all search indices, making sure they behave the same.
schilkp
force-pushed
the
schilkp/fuse_redirect_subpages
branch
from
3520308 to
0212300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all search index styles manually gathered items which should be included from the Library. This lead to subtly different inclusion rules. For instance, the
elasticlunrsearch index would include the sub-pages of redirect sections, whilefusedid not.This patch centralizes the collection into a single routine which is used for all search indices, making sure they behave the same.
This replaces #3079.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?