⚙️Setting: Update ci.yml

[skyblue1232]

🔥 작업 내용

• ex) 로그인 페이지 UI 및 반응형 구현

🤔 추후 작업 사항

• ex) 소셜 로그인 연동 (카카오, 구글)

🔗 이슈

• close #

PR Point (To Reviewer)

• ex) 로그인 입력 검증 로직 적절한지 확인 부탁드립니다.

📸 피그마 스크린샷 or 기능 GIF

(작업 내역 스크린샷)

Summary by CodeRabbit

• Chores
  • Updated continuous integration workflow to also run on pull requests targeting the main and develop branches, in addition to existing push events. This enhances automated checks during review without changing app functionality or deployment behavior.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
af-fe	Ready	Preview	Comment	Oct 13, 2025 4:31am

[coderabbitai]

Walkthrough

The CI workflow in .github/workflows/ci.yml now also runs on pull_request events targeting develop and main, alongside the existing push trigger. No job steps, deployments, or other workflow logic were modified.

Changes

Cohort / File(s)	Summary of changes
CI Workflow triggers .github/workflows/ci.yml	Added pull_request trigger for branches develop and main; existing push trigger retained. No step or deployment changes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Dev as Developer
    participant GH as GitHub
    participant GHA as GitHub Actions Runner
    participant CI as CI Workflow

    Dev->>GH: Push commit (develop/main)
    GH-->>GHA: Trigger workflow_dispatch (push)
    GHA->>CI: Execute jobs

    Dev->>GH: Open/Update Pull Request (to develop/main)
    Note over GH,CI: New trigger added
    GH-->>GHA: Trigger workflow_dispatch (pull_request)
    GHA->>CI: Execute same jobs (no step changes)

Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

test

Suggested reviewers

• KongMezu
• jjangminii

Poem

I thump my paws at PR’s call,
New triggers hop—no steps to haul.
On push we dash, on PR too,
The pipeline runs, both tried-and-true.
A whisker twitch, a carrot cheer—
CI now listens far and near! 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is unchanged from the repository template and contains only placeholder/example text without any details about the actual CI workflow change, missing a filled-out 작업 내용 section, issue reference, specific review points, or any attachments.	Please replace the placeholder template entries with a concise description of adding the pull_request trigger to the CI workflow in 작업 내용, include the relevant issue number under 이슈, specify the PR Point for reviewer focus, and attach any relevant logs or screenshots demonstrating the change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title “Update ci.yml” directly references the main change in the pull request, namely updating the CI configuration file, and does so in a concise and clear manner that will be understandable to teammates reviewing the history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch skyblue1232-patch-1

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🏷️ Labeler has automatically applied labels based on your PR title, branch name, or commit message.
Please verify that they are correct before merging.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 778170d and 906d258.

📒 Files selected for processing (1)

• .github/workflows/ci.yml (1 hunks)

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Guard the deploy step when running on pull_request.

By adding the pull_request trigger, this job now runs for PRs, but the deploy step still executes and requires repo secrets. For PRs from forks (or when you simply want CI-only runs), those secrets are unavailable, so the workflow will now fail and block reviews. Please add an if: github.event_name == 'push' guard (either on the whole job or just the deploy step) so deployments only happen on pushes while the rest of the job can still validate PRs.

       - name: Deploy to Vercel
+        if: github.event_name == 'push'
         uses: amondnet/vercel-action@v25

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	pull_request:
	branches: [develop, main]
	- name: Deploy to Vercel
	if: github.event_name == 'push'
	uses: amondnet/vercel-action@v25

🤖 Prompt for AI Agents

.github/workflows/ci.yml lines 6-7: because the workflow now triggers on
pull_request the deploy step runs during PRs and fails when repo secrets aren’t
available; add a guard so deployments only run on pushes by adding an if:
github.event_name == 'push' condition (either on the deploy step itself or on
the entire job) so the job still validates PRs but the deploy step is skipped
for pull_request events.

[KongMezu]

확인했습니다 🙇‍♂️ 빠른 피드백 감사합니다 !