Skip to content

⚙️Setting : 컬러 토큰명 변경#16

Merged
KongMezu merged 1 commit intodevelopfrom
initsetting
Oct 14, 2025
Merged

⚙️Setting : 컬러 토큰명 변경#16
KongMezu merged 1 commit intodevelopfrom
initsetting

Conversation

@KongMezu
Copy link
Contributor

@KongMezu KongMezu commented Oct 14, 2025

🔥 작업 내용

  • 컬러 토큰명 변경(통일)
    -> SVG sprite 에서 컬러 토큰을 받아오지 못한 문제를 해결하기 위해 통일 시켰습니다.

🤔 추후 작업 사항

  • 디자인 시스템 및 빌드 세팅 완료 후 컴포넌트 제작

🔗 이슈

PR Point (To Reviewer)

  • 해당 브랜치 global.csstailwind.config.js 파일 패치 후
    SVG Sprite current color 변경이 잘 되는지 확인 부탁드립니다.

📸 피그마 스크린샷 or 기능 GIF

Summary by CodeRabbit

  • Style

    • Renamed color palette tokens to mint/pink/gray scales and aligned blue/red tokens for consistency.
    • Normalized spacing token formatting without changing values.
    • No visual changes expected.
  • Chores

    • Updated theme mappings to use the new color variable names across the design system.

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
af-fe Ready Ready Preview Comment Oct 14, 2025 0:21am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Renamed CSS color token variables in src/styles/globals.css and updated Tailwind mappings in tailwind.config.js to reference the new mint/pink/gray/blue/red variable names. Also normalized spacing token formatting in Tailwind. No logic or public API structure changes; values remain the same.

Changes

Cohort / File(s) Summary of edits
Color token rename in CSS root
src/styles/globals.css
Replaced --color-main-*, --color-secondary-*, --color-gray-*, --color-blue, --color-red-* with --mint-50..900, --pink-50..900, --gray-50..900, --blue-400, --red-300/400; values unchanged; comments updated.
Tailwind theme remap and formatting
tailwind.config.js
Updated theme colors to use new CSS vars (mint, pink, gray, blue-400, red-300/400); normalized spacing key formatting (values unchanged).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

setting, style

Suggested reviewers

  • skyblue1232

Poem

I nibble on tokens—mint to pink delight,
Gray pebbles aligned, all values just right.
Blue hops at 400, red twins in a row,
Tailwind breezes map where variables go.
Thump-thump! My styles are crisp and bright. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly indicates that the PR is about changing color token names, which matches the primary change in global.css and tailwind.config.js despite the minor prefix noise.
Description Check ✅ Passed The PR description follows the repository template by including sections for 작업 내용, 추후 작업 사항, 이슈, PR Point, and the screenshot header, clearly describing what was changed, why, what to review, and linking the related issue. While no screenshot or GIF is provided under the last header, all mandatory sections are present with detailed content.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch initsetting

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be34278 and f95613a.

📒 Files selected for processing (2)
  • src/styles/globals.css (1 hunks)
  • tailwind.config.js (2 hunks)
🔇 Additional comments (3)
tailwind.config.js (2)

8-50: LGTM! Color mappings correctly align with CSS variable renaming.

All Tailwind color utilities properly reference the new CSS variable names (--mint-, --pink-, --gray-*, --blue-400, --red-300/400) defined in globals.css. The mapping structure is consistent and follows Tailwind conventions.

Verify the SVG sprite color token issue is resolved:

As mentioned in the PR description, please test that SVG sprites now correctly pick up the current color token. If you have test components or examples, verify they render with the expected colors after this change.


77-88: Minor spacing formatting cleanup.

The spacing token formatting has been normalized (removed trailing spaces). Values remain unchanged—this is purely a cosmetic improvement.

src/styles/globals.css (1)

10-49: Old color token references removed. No remaining color-main-*, color-secondary-*, or color-gray-* usages found.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the setting 패키지 설치, 개발 설정 label Oct 14, 2025
@github-actions
Copy link

🏷️ Labeler has automatically applied labels based on your PR title, branch name, or commit message.
Please verify that they are correct before merging.

@github-actions github-actions bot added the comment 필요한 주석 추가 및 변경 label Oct 14, 2025
@github-actions
Copy link

🏷️ Labeler has automatically applied labels based on your PR title, branch name, or commit message.
Please verify that they are correct before merging.

Copy link
Contributor

@skyblue1232 skyblue1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존이랑 어떤 차이가 있는지 궁금하네요

@KongMezu KongMezu merged commit e62b4b9 into develop Oct 14, 2025
7 checks passed
@KongMezu KongMezu changed the title setting : 컬러 토큰명 변경 ⚙️Setting : 컬러 토큰명 변경 Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comment 필요한 주석 추가 및 변경 setting 패키지 설치, 개발 설정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants