Skip to content

Revert "✨Feat: node page layout " #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjangminii wants to merge 1 commit into from
Closed

Revert "✨Feat: node page layout " #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/main/Board.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Header } from '@/shared/components';

import Boardgame from '@/pages/main/components/board/Boardgame';
import { useRouter } from 'next/router';
import router from 'next/router';

const Board = () => {
const router = useRouter();
return (
<div className='relative w-full h-[100vh] bg-[#46d1cd] overflow-auto'>
<Header title='지도' onClick={() => router.back()} />
Comment on lines +4 to 9
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

잘못된 라우터 사용 패턴으로 런타임 오류가 발생합니다.

Next.js는 router를 default export로 제공하지 않습니다. next/router에서 default import한 router는 undefined이거나 사용할 수 없는 객체이므로 router.back() 호출 시 런타임 에러가 발생합니다.

Next.js 15 (Pages Router)에서는 반드시 useRouter 훅을 사용해야 합니다.

다음과 같이 수정하세요:

-import router from 'next/router';
+import { useRouter } from 'next/router';

 const Board = () => {
+  const router = useRouter();
+
   return (
     <div className='relative w-full h-[100vh] bg-[#46d1cd] overflow-auto'>
       <Header title='지도' onClick={() => router.back()} />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
import router from 'next/router';
const Board = () => {
const router = useRouter();
return (
<div className='relative w-full h-[100vh] bg-[#46d1cd] overflow-auto'>
<Header title='지도' onClick={() => router.back()} />
import { useRouter } from 'next/router';
const Board = () => {
const router = useRouter();
return (
<div className='relative w-full h-[100vh] bg-[#46d1cd] overflow-auto'>
<Header title='지도' onClick={() => router.back()} />
🤖 Prompt for AI Agents 
In src/pages/main/Board.tsx around lines 4 to 9, the file imports a default
router from 'next/router' and calls router.back(), which causes a runtime error
because Next.js requires the useRouter hook; replace the default import with a
named import of useRouter from 'next/router', call const router = useRouter() at
the top of the Board component, and then use router.back() (or router.back in an
event handler) so the router instance is obtained via the React hook.

Expand Down
71 changes: 0 additions & 71 deletions src/pages/main/Node.tsx
View file
Open in desktop

This file was deleted.

13 changes: 1 addition & 12 deletions src/pages/main/components/board/Boardgame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
'use client';
import Image from 'next/image';
import { boardData } from '@/shared/constants/main/boardData';
import { useRouter } from 'next/router';

const Boardgame = () => {
const router = useRouter();
return (
<div className='relative w-full h-full bg-[#46d1cd] overflow-hidden'>
<Image
Expand Down Expand Up @@ -33,16 +31,7 @@ const Boardgame = () => {
}

return (
<div
key={key}
onClick={() => {
// TODO : 로그인 여부 체크
router.push({
pathname: '/main/Node',
query: { label: cell.label },
});
}}
></div>
<div key={key} onClick={() => console.log(cell.label)}></div>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

네비게이션 기능이 완전히 제거되었습니다.

활성 셀 클릭 시 페이지 이동 대신 콘솔 로그만 출력하도록 변경되어, 사용자에게는 클릭해도 아무 반응이 없는 것처럼 보입니다. 이것이 의도된 동작인지 확인이 필요합니다.

이 변경이 의도된 것인지, 아니면 다른 네비게이션 방식으로 대체해야 하는지 확인해주세요.

🏁 Script executed:

#!/bin/bash
# Examine Boardgame.tsx to verify current state
echo "=== Checking Boardgame.tsx content ==="
if [ -f "src/pages/main/components/board/Boardgame.tsx" ]; then
  cat "src/pages/main/components/board/Boardgame.tsx"
else
  echo "File not found at expected location"
  find . -name "Boardgame.tsx" -type f 2>/dev/null | head -5
fi

Length of output: 1060

🏁 Script executed:

#!/bin/bash
# Check for useRouter imports in the file
echo "=== Checking for router imports ==="
rg -n "useRouter|router\.push|import.*router" src/pages/main/components/board/Boardgame.tsx 2>/dev/null || echo "No router-related patterns found"

Length of output: 68

🏁 Script executed:

#!/bin/bash
# Check git diff to understand what changed
echo "=== Checking git diff for the file ==="
git diff HEAD -- src/pages/main/components/board/Boardgame.tsx 2>/dev/null | head -100 || echo "Git diff not available"

Length of output: 38

🏁 Script executed:

#!/bin/bash
# Look at surrounding context around line 34
echo "=== Context around line 34 ==="
sed -n '25,45p' src/pages/main/components/board/Boardgame.tsx 2>/dev/null || echo "Cannot access line range"

Length of output: 451

🏁 Script executed:

#!/bin/bash
# Check git log history for this file
echo "=== Git log for Boardgame.tsx ==="
git log --oneline -20 -- src/pages/main/components/board/Boardgame.tsx 2>/dev/null | head -10

echo -e "\n=== Recent commits showing the file ==="
git log -p --follow -3 -- src/pages/main/components/board/Boardgame.tsx 2>/dev/null | head -150

Length of output: 313

🏁 Script executed:

#!/bin/bash
# Search for router usage in similar board/game files
echo "=== Checking for router patterns in related files ==="
rg -n "router\.push|useRouter" src/pages/main/components/board/ src/pages/main/components/ 2>/dev/null | head -20

echo -e "\n=== Looking for onClick handlers with navigation ==="
rg -n "onClick.*router|onClick.*push" src/pages/main/components/ 2>/dev/null | head -20

Length of output: 107

🏁 Script executed:

#!/bin/bash
# Check PR metadata or description
echo "=== Checking for PR or commit message context ==="
git log -1 --pretty=format:"%B" 2>/dev/null

echo -e "\n=== Current branch info ==="
git branch -v 2>/dev/null || echo "Not in git context"

Length of output: 258

🏁 Script executed:

#!/bin/bash
# Check git log history
echo "=== Git log for Boardgame.tsx ==="
git log --oneline -10 -- src/pages/main/components/board/Boardgame.tsx 2>/dev/null || echo "No git history"

echo -e "\n=== Recent commits ==="
git log -1 --pretty=format:"%B" 2>/dev/null || echo "No commit message"

Length of output: 330

🏁 Script executed:

#!/bin/bash
# Search for router usage in board/game related files
echo "=== Router patterns in board components ==="
rg -n "router\.push|useRouter|onClick.*router" src/pages/main/components/board/ -A2 -B2 2>/dev/null || echo "No router patterns found"

echo -e "\n=== onClick handlers in board components ==="
rg -n "onClick" src/pages/main/components/board/ -B1 -A1 2>/dev/null | head -40

Length of output: 373

🏁 Script executed:

#!/bin/bash
# Check boardData structure to understand intent
echo "=== Checking boardData constants ==="
cat src/shared/constants/main/boardData.ts 2>/dev/null || cat src/shared/constants/main/boardData.js 2>/dev/null || find . -name "boardData*" -type f 2>/dev/null

Length of output: 1003

리버트 커밋으로 인한 의도된 네비게이션 제거 확인됨 - 하지만 console.log 제거 필요

이 변경은 "Revert '✨Feat: node page layout '" 커밋의 일부로서 의도된 것입니다. 그러나 onClick 핸들러의 console.log(cell.label)은 프로덕션 코드에서 제거되어야 합니다. 현재는 사용자에게 보이는 효과가 없는 디버그 코드만 남아있습니다.

  • Line 34: console.log(cell.label) 제거 또는 용도 명확화 필요
🤖 Prompt for AI Agents 
In src/pages/main/components/board/Boardgame.tsx around line 34, the onClick
handler currently only calls console.log(cell.label) which is leftover debug
code from the revert; remove the console.log from the handler — either delete
the onClick prop entirely if clicks should be no-op, or replace it with the
intended navigation/handler (e.g., call the real click handler or router
navigation) and ensure no console.* calls remain in production.

);
}),
)}
Expand Down
3 changes: 1 addition & 2 deletions src/pages/main/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ import { cn } from '@/shared/lib';
import StampBoard from './components/stampBoard/StampBoard';
import { ControlBar } from '@/shared/components';
import Image from 'next/image';
import { useRouter } from 'next/router';
import router from 'next/router';
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

잘못된 라우터 사용 패턴으로 런타임 오류가 발생합니다.

Board.tsx와 동일한 문제입니다. Next.js는 router를 default export로 제공하지 않으므로, 현재 코드는 보드판 클릭 시 페이지 이동이 실패하고 런타임 에러가 발생합니다.

다음과 같이 수정하세요:

-import router from 'next/router';
+import { useRouter } from 'next/router';

 export default function MainPage() {
+  const router = useRouter();
+
   return (
     <div

Also applies to: 34-36

🤖 Prompt for AI Agents 
In src/pages/main/index.tsx around line 5 (and also affecting lines 34-36), the
file incorrectly imports router as a default export from 'next/router', causing
runtime errors when navigating; replace the default import with the useRouter
hook (import { useRouter } from 'next/router') and obtain router inside the
component (const router = useRouter()) before calling router.push or other
navigation methods, then update the code at lines 34-36 to use that local router
instance for navigation.

import { BottomNav } from '@/shared/components/tab/BottomNav';

export default function MainPage() {
const router = useRouter();
return (
<div
className={cn(
Expand Down
1 change: 0 additions & 1 deletion src/shared/icons/iconNames.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export const iconNames = [
"KakaoIcon",
"MapPin",
"MapPin_",
"PressStamp",
"Save",
"Stamp",
"User",
Expand Down
3 changes: 1 addition & 2 deletions src/shared/icons/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// 이 파일은 자동 생성 파일입니다. (직접 수정 금지)
import './source/backto.svg';
import './source/CalendarBlank.svg';
import './source/Caret.svg';
import './source/ChatCircle.svg';
Expand All @@ -12,11 +13,9 @@ import './source/HouseSimple.svg';
import './source/KakaoIcon.svg';
import './source/MapPin.svg';
import './source/MapPin_.svg';
import './source/PressStamp.svg';
import './source/Save.svg';
import './source/Stamp.svg';
import './source/User.svg';
import './source/backto.svg';
import './source/x.svg';

export { Icon } from './components/icon';
1 change: 0 additions & 1 deletion src/shared/icons/source/PressStamp.svg
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions src/shared/utils/handleGetLocation.ts
View file
Open in desktop

This file was deleted.

Loading