-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove errant underscore in AABB abbreviation #255
base: master
Are you sure you want to change the base?
Conversation
AABB stands for Axis-Aligned Bounding Box. In one of the ray tracing flag enumerations, it is pluralized as AABBs. This confused the shouty snake case generation. There was already a special handling for NaN, add another case for AABBs and refactor the handling into its own function in utils. This compares to what has been done prior for converting strings into Ident. Update the autogen files to use the new naming rules. Format all code, which made small edits to code I didn't otherwise modify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for commonizing it too!
It is probably unfeasible to match
on a few input strings and capitalizing them by hand, right?
Depends on how you define unfeasible I guess. However, I think the replace after conversion approach (which I extended with another case) is more robust. Here are three potential strategies I see (in ascending order of my preference):
If you feel strongly about using another approach (including any I didn't enumerate), I could change the patch to do that, but I think it is best as-is. |
Resolve the clippy and format errors to pass the CI. Also, replace a use of to_snake_case()...uppercase() with shouty_snake_case.
What is next? I can be patient if people need more time to review- I just want to make sure that it isn't waiting on me. |
AABB stands for Axis-Aligned Bounding Box. In one of the ray tracing flag enumerations, it is pluralized as AABBs. This confused the shouty snake case generation.
There was already a special handling for NaN, add another case for AABBs and refactor the handling into its own function in utils. This compares to what has been done prior for converting strings into Ident.
Update the autogen files to use the new naming rules.
Format all code, which made small edits to code I didn't otherwise modify.