Skip to content

Implement clip-distances extension for GL and Vulkan backends #7730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

dzamkov
Copy link
Contributor

@dzamkov dzamkov commented May 26, 2025

Connections
#6236: Partially resolves

Description
Implements the clip-distances extension for GL and Vulkan backend. This was already implemented in Naga for the most part, so we just need to hook it up in the adapters. The GL backend is a bit tricky because we need to manually enable each clip plane we're using with the GL API.

Testing

  • Added Naga snapshot tests
  • Added GPU test
  • Integrated into personal project and verified clip planes work as expected

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@dzamkov dzamkov requested a review from a team as a code owner May 26, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant