implement debugPrintf in msl & spv#9389
Conversation
|
@ErichDonGubler test is failing : |
|
added vulkan support as well |
atlv24
left a comment
There was a problem hiding this comment.
Yay, it'll be great to have this! Some feedback, mostly style but also docs and a performance fix.
I'd appreciate safety comments on all the newly added unsafe blocks.
|
@atlv24 should be good to go |
atlv24
left a comment
There was a problem hiding this comment.
This needs some naga validation fail tests showing that string literals are banned from non debugPrintf locations, and also that debugPrintf is not allowed unless the extension is present.
|
User defined format strings are famously unsafe and this seems to implicitly assume that all backends going forward will have the same format string formats. Maybe it would be a cool improvement to support (basic) Rust style format strings instead? Then again, maybe too much work for a debug feature. See also gfx-rs/naga#2563. That seems to support printf in OpenGL via |
|
@atlv24 check it out |
atlv24
left a comment
There was a problem hiding this comment.
This is good to merge now, thanks!
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
Co-authored-by: atlv <email@atlasdostal.com>
|
Maybe run |
|
This still has multiple pending comments that need addressing |
Connections
related to #7662
Description
now you can printf stuff in wgsl using metal backend, should be able add vulkan as well in the future :
Testing
added an example
Squash or Rebase?
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.