Hal ray tracing pipelines#9464
Open
Vecvec wants to merge 11 commits intogfx-rs:trunkfrom
Open
Conversation
4acd17b to
16fceae
Compare
16fceae to
bb84f1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
The hal part of #9450 (split to be easier to review)
Description
Adds ray tracing pipelines to wgpu-hal. Adds a feature and limits for this. However, these limits aren't validated because they are only usable through the hal (for now...). Naming is mostly based off Vulkan and DX12's, but I changed the name of shader binding tables to pipeline group data (they aren't a table and the bindings are of groups of shaders [closest hit group, miss group, intersection group (not to be confused with intersection shader)])
Testing
Testing is difficult in the hal, but these changes are the same as the hal part of #9450, which has some basic testing
Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.