Enable wgpu_validate_locks#9479
Draft
andyleiserson wants to merge 21 commits intogfx-rs:trunkfrom
Draft
Conversation
This does two things: 1. Installs a panicking device loss handler when running GPU tests. 2. Allows expect-failure cases looking for an "unexpected" driver error to match even when `internal_error_panic` is off. Normally, `cargo xtask test` runs with `--all-features`, enabling `internal_error_panic`, which always panics immediately on an unexpected driver error. To avoid confusion if running tests without that feature, also match such errors when the feature is disabled and they manifest as device loss.
Fix a hypothetical race condition in `Device::maintain`
andyleiserson
force-pushed
the
jj-push-srqw
branch
from
e401c0c to
b6f4b86
Compare
andyleiserson
force-pushed
the
jj-push-srqw
branch
from
c72dd88 to
a754311
Compare
andyleiserson
force-pushed
the
jj-push-srqw
branch
from
fc7b6f0 to
bcb94c8
Compare
This was referenced May 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
When one pull request builds on another, please put "Depends on
#NNNN" towards the top of its description. This helps maintainers
notice that they shouldn't merge it until its ancestor has been
approved. Don't use draft PR status to indicate this.
Description
Describe what problem this is solving, and how it's solved.
Testing
Explain how this change is tested.
Squash or Rebase?
If your pull request contains multiple commits, please indicate whether
they need to be squashed into a single commit before they're merged,
or if they're ready to rebase onto
trunkas they stand. In thelatter case, please ensure that each commit passes all CI tests, so
that we can continue to bisect along
trunkto isolate bugs.Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.