Skip to content

add a tiny tolerance in floating-point arithmetic #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victorsacek merged 1 commit into from
Apr 10, 2026
Merged

add a tiny tolerance in floating-point arithmetic #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions src/DMSwarm_move.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,17 +123,33 @@ PetscInt get_k(PetscReal cz){
}

PetscReal get_rx(PetscReal cx, PetscInt i){
PetscReal rx = (cx-i*dx_const)/dx_const;
if (rx<0 || rx>1) {printf("weird rx=%f\n",rx); exit(1);}
PetscReal rx = (cx - i*dx_const) / dx_const;

return rx;
// tolerate tiny floating-point deviations around the boundaries.
if (rx < -1e-12 || rx > 1.0 + 1e-12) {
printf("weird rx=%.16e cx=%.16e i=%d\n", rx, cx, i);
exit(1);
}

if (rx < 0.0) rx = 0.0;
if (rx > 1.0) rx = 1.0;

return rx;
}

PetscReal get_rz(PetscReal cz, PetscInt k){
PetscReal rz = (cz-(-depth+k*dz_const))/dz_const;
if (rz<0 || rz>1) {printf("weird rz=%f\n",rz); exit(1);}
PetscReal rz = (cz - (-depth + k*dz_const)) / dz_const;

// tolerate tiny floating-point deviations around the boundaries.
if (rz < -1e-12 || rz > 1.0 + 1e-12) {
printf("weird rz=%.16e cz=%.16e k=%d\n", rz, cz, k);
exit(1);
}

if (rz < 0.0) rz = 0.0;
if (rz > 1.0) rz = 1.0;

return rz;
return rz;
}

PetscErrorCode moveSwarm(int dimensions, PetscReal dt)
Expand Down
Loading