Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ggml_is_view_op
is a useful API.Use case 1
It is used by
test-backend-ops.cpp
.Use case 2
llama.cpp/src/llama.cpp
Lines 8178 to 8179 in 73e2ed3
Let's say
cur
is a view operation and its source is on another backend, then this would be problematic.if (ggml_backend_supports_op(backend.get(), cur) && !ggml_is_view_op(cur->op))
seems better.By the way, PR #10825 is useful for checking (visualizing) these scenarios.