vulkan: add fwht support for Intel with shmem reduction#23964
Open
0cc4m wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I don't get the failure of the CI Windows Intel run, on Linux. @rillomas Any ideas? |
Contributor
I think the workgroup size might be too large, 512*4 (would be above NVIDIA's limit, at least). Check VVL? |
Contributor
Author
|
Right, I missed that. I'll just keep it closer to the subgroup-based shader, that should also be easier to maintain. |
jeffbolznv
approved these changes
Jun 1, 2026
Contributor
The crash in Windows CI was the same as #23687 (comment) . I also checked the latest driver 32.0.101.8826 but it was still crashing so we'll need to wait until the fix is deployed, at least for Xe2/3 environments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a FWHT shader path that does not rely on subgroup size and collectives for Intel GPUs.
Requirements