Skip to content

vulkan: add fwht support for Intel with shmem reduction#23964

Open
0cc4m wants to merge 4 commits into
masterfrom
0cc4m/vulkan-fwht-intel
Open

vulkan: add fwht support for Intel with shmem reduction#23964
0cc4m wants to merge 4 commits into
masterfrom
0cc4m/vulkan-fwht-intel

Conversation

@0cc4m
Copy link
Copy Markdown
Contributor

@0cc4m 0cc4m commented Jun 1, 2026

Overview

Add a FWHT shader path that does not rely on subgroup size and collectives for Intel GPUs.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES, Claude wrote the code, I corrected and reviewed.

@0cc4m 0cc4m requested a review from a team as a code owner June 1, 2026 10:33
@github-actions github-actions Bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jun 1, 2026
@0cc4m
Copy link
Copy Markdown
Contributor Author

0cc4m commented Jun 1, 2026

I don't get the failure of the CI Windows Intel run, on Linux. @rillomas Any ideas?

@jeffbolznv
Copy link
Copy Markdown
Contributor

I don't get the failure of the CI Windows Intel run, on Linux. @rillomas Any ideas?

I think the workgroup size might be too large, 512*4 (would be above NVIDIA's limit, at least). Check VVL?

@0cc4m
Copy link
Copy Markdown
Contributor Author

0cc4m commented Jun 1, 2026

Right, I missed that. I'll just keep it closer to the subgroup-based shader, that should also be easier to maintain.

@rillomas
Copy link
Copy Markdown
Contributor

rillomas commented Jun 2, 2026

I don't get the failure of the CI Windows Intel run, on Linux. @rillomas Any ideas?

The crash in Windows CI was the same as #23687 (comment) . I also checked the latest driver 32.0.101.8826 but it was still crashing so we'll need to wait until the fix is deployed, at least for Xe2/3 environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants