add minicpmv46 downsample#25993
Open
tc-mb wants to merge 1 commit into
Open
Conversation
Signed-off-by: tc-mb <tianchi_cai@icloud.com>
github-actions
Bot
added
server
mtmd
tc-mb
marked this pull request as ready for review
July 22, 2026 11:26
ngxson
requested changes
Jul 22, 2026
Comment on lines
+2244
to
+2248
| add_opt(common_arg( | ||
| {"--downsample-mode"}, "N", | ||
| "MiniCPM-V 4.6 ViT downsample mode (4 or 16), default: 16 (model default)", | ||
| [](common_params & params, int value) { | ||
| if (value != 4 && value != 16) { |
Collaborator
There was a problem hiding this comment.
adding a single-use-case flag is generally not expected in the project. this flag should be removed.
instead, many models have the downsample as a GGUF metadata (read as n_merge in clip.cpp), I think it's better here to just distribute specific GGUF with the correct downsample values (will be 2 extra mmproj files in this case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This branch adds configurable visual token downsampling for MiniCPM-V 4.6: