Skip to content

skill: create add-new-model and code-review#26042

Merged
allozaur merged 12 commits into
masterfrom
xsn/skill_add_models
Jul 24, 2026
Merged

skill: create add-new-model and code-review#26042
allozaur merged 12 commits into
masterfrom
xsn/skill_add_models

Conversation

@ngxson

@ngxson ngxson commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Overview

Add skills for AI coding.

While this doesn't avoid low-effort slop contributions, it will hopefully reduce the review effort by guiding AI to write better code from the beginning.

2 skills are added:

  • add-new-model: can be viewed as an extension of HOWTO-add-model.md with more detailed guidance
  • code-review: per-component review skill, currently support src/models/, server and GGML changes

How these skills are made?

  • I draft a list of requirements / common pitfalls
  • I asked the AI to read N recent PRs to confirm & refine that list
  • Then finally write the SKILL.md
  • I review the output manually and made some adjustments

CC @ggml-org/maintainers for review & discussions

Requirements

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 23, 2026
Comment thread skills/code-review/SKILL.md
Comment thread skills/add-new-model/SKILL.md Outdated
Comment thread skills/add-new-model/SKILL.md
ngxson and others added 4 commits July 23, 2026 18:42
Co-authored-by: Piotr Wilkin (ilintar) <piotr.wilkin@syndatis.com>
Co-authored-by: Xuan-Son Nguyen <thichthat@gmail.com>
@ngxson

ngxson commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

I've been testing the code-review skill on some recent PRs and it shows very promising results, mostly aligned with project's convention.

Will experiment with adding it to @ggml-gh-bot and allow maintainers to trigger it manually.

@ngxson

ngxson commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

I kinda need the code-review skill now, is this good to merge @ggml-org/maintainers ?

Will experiment with @ggml-gh-bot review command next, but that will be my low-priority task. For now it's still quite helpful to ask pi / claude to "review PR ... using code-review skill", that works quite well

@ngxson ngxson mentioned this pull request Jul 24, 2026
@allozaur
allozaur merged commit 77095ee into master Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants