[net] Fix telnet incoming DM handling #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes telnet requirement to discard received data after ^C or ^O until DM received, with DM handling having been untested from previous PR comment #2566 (comment).
Coding error found during discussion in Mellvik/TLVC#217 (comment). Thanks @Mellvik for testing my macOS telnetd.
Testing now shows ^C handling with discarding working well with ELKS telnetd and macOS telnetd using DM instead of timeout, with no lost data and shell prompt displayed after discarding stopped.
^O discards output, also without sending ENTER after DM. On very long listings, ^O discards output for several seconds, then ^O is displayed, and if a character is typed, output resumes as expected, with ^O^R displayed after several more seconds. This is likely expected behavior of the remote shell. I will be leaving this as is until more information is found regarding IAC AO operations(s).