Adding a scalable relaxation of Elkan's pruning algorithm #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghamerly
requested changes
Sep 9, 2019
| delete [] lower; | ||
|
|
||
| if (lower) | ||
| delete [] lower; |
There was a problem hiding this comment.
It's not clear to me why you are making these changes to lower here (and below). I worry about the effects in other files that rely on this base class.
I think that if numLowerBounds == 0, everything should "just work" (i.e. it's okay to allocate and deallocate zero-length array). Further, with this line in particular, if lower == NULL, then it's fine to call delete on it.
There was a problem hiding this comment.
Correct! I will update this.
There was a problem hiding this comment.
I ran a benchmark using the driver-experiment under valgrind and verified all algorithms produce the correct result (-DMONITOR_ACCURACY) with no leaks reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MTI algorithm is presented in:
Mhembere, D., Zheng, D., Priebe, C.E., Vogelstein, J.T. and Burns, R., 2017, June. knor: A NUMA-optimized in-memory, distributed and semi-external-memory k-means library. In Proceedings of the 26th International Symposium on High-Performance Parallel and Distributed Computing (pp. 67-78). ACM.
I can add Python binding in another PR if necessary