Enhancements in Testing and Functionality#11
Open
bkcompton wants to merge 8 commits into
Open
Conversation
added 8 commits
July 13, 2019 12:00
… and commonErrorRetry). Also, updated documentation on retry to indicate it now supports a function or an Integer.
…ed by Athena an S3 constructors. This was needed for me to avoid the EMFILE error which occurs on macOS when you have more than 256 open file descriptors. Also occurs in AWS Lambda environment.
Author
|
The last commit allows for the caller to pass in the optional aws params object to the AthenaExpress constructor which is then used in the AWS and Athena constructors for additional configurability. This was required by my AWS Lambda which was creating more then the default open file descriptor setting in the Lambda environment. This is overridable via the following setting in https.Agent constructor... (I set it to 5000 below). The resolved error message found in CloudFormation: Usage: I hope this helps others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced Tests (almost full coverage)
Fixed Issue: CTAS Queries Don't Work
Conformed to strict Sonar and es-lint rules
Added ability to configure timeouts for both retry and common error scenarios
Added ability to set the Athena workgroup in configuration (Allows workgroup level security)
Increased the version numbers on test tools and updated package.json to have debug script that can be used in .vscode's launch.json.