Skip to content

Allow an AWS region to be passed into the library#30

Open
jonathankeebler wants to merge 1 commit into
ghdna:masterfrom
jonathankeebler:master
Open

Allow an AWS region to be passed into the library#30
jonathankeebler wants to merge 1 commit into
ghdna:masterfrom
jonathankeebler:master

Conversation

@jonathankeebler
Copy link
Copy Markdown

I ran into a problem where I was trying to make Athena queries against two AWS regions simultaneously. I was using aws.config.update to set my region each time, but that's a global config that would change in-between the Athena and S3 calls in athena-express.

To solve, I've added a new config parameter region that can be passed into the constructor. If it's not passed, the default behaviour will set the region.

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 27, 2019

Pull Request Test Coverage Report for Build 99

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 91: 0.0%
Covered Lines: 6
Relevant Lines: 6

💛 - Coveralls

@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2021

Is there a chance to merge it into the main code as we need the same feature here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants