Allow an AWS region to be passed into the library#30
Open
jonathankeebler wants to merge 1 commit into
Open
Conversation
…thena and S3 instances
|
Is there a chance to merge it into the main code as we need the same feature here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a problem where I was trying to make Athena queries against two AWS regions simultaneously. I was using
aws.config.updateto set my region each time, but that's a global config that would change in-between the Athena and S3 calls inathena-express.To solve, I've added a new config parameter
regionthat can be passed into the constructor. If it's not passed, the default behaviour will set the region.