Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result reuse feature addition #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

buseta77
Copy link

Having used this library a lot, I decided to create a PR regarding a feature and an issue that helped me most.

  1. The feature I added is the built-in "Result Reuse" feature that Athena provides in the management console. By enabling "reuse" config I added, you can use previously cached result up to 7 days, which helps so much with execution times.
  2. Second one is a bug I encountered: while library is gathering streamed data from Athena, if there are some weird characters in the data and somehow it leads to incorrect data types, then addDataType function hangs forever and not responding. By simply adding a try-catch block, it returns data as expected and makes the incorrect data null so that it can be handled in the app logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant