This repository was archived by the owner on May 21, 2025. It is now read-only.
Async#513
Open
richbai90 wants to merge 7 commits into
Open
Conversation
added 7 commits
October 6, 2017 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow local data to be a function that may optionally return a promise. In my case I wanted to query an API but that API did not meet any decent standard that could easily be made sense of. In this case the only thing to do was make a service to query the API and return the results as though they were local results and search those. I updated the tests to show that the new features work and no regression was found. I apologize for the formatting my IDE does it automatically.