Skip to content

feat(filter): add collectionLazy callback to Column Filter #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 20, 2025

as discussed in #1922

  • when user has lots of columns, it could be useful to load the ms-select collection only when opening the select dropdown via a new collectionLazy callback
  • this new collectionLazy option is only available and implemented for Single/MultipleSelect Filter
  • a loading/spinner might be implemented in ms-select library in a future release

brave_uUG4UqHHKt

Copy link

stackblitz bot commented Apr 20, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the title feat(filter): add collectionLazy to Column Filter feat(filter): add collectionLazy callback to Column Filter Apr 20, 2025
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (e595484) to head (a3d18df).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #1923     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         187      187             
  Lines       34547    34565     +18     
  Branches    10278    10277      -1     
=========================================
+ Hits        34521    34539     +18     
  Misses         26       26             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding ghiscoding merged commit 23bbbeb into master Apr 22, 2025
13 checks passed
@ghiscoding ghiscoding deleted the feat/collection-lazy branch April 22, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant