Skip to content

add smsg service apis#2

Open
jmszrm wants to merge 2 commits intoghost-coin:masterfrom
jmszrm:master
Open

add smsg service apis#2
jmszrm wants to merge 2 commits intoghost-coin:masterfrom
jmszrm:master

Conversation

@jmszrm
Copy link
Copy Markdown

@jmszrm jmszrm commented Jul 29, 2020

There are some services for Ghost RPC apis. Smsg service is ready to use. Everyone can send, view, list, delete messages.

@gmkaddar
Copy link
Copy Markdown

This isn't done, or at least I don't understand how it works haha.

Some issues I found:
Require /services doesn’t work everything is in /lib
No error handling when RPC port is unavailable. Uncaught error.
Error handling on incorrect user details non existent, uncaught error.
Running index, prints blockchain info as expected but there's no express or API handling or routing or anything to make this do anything.

All the code seems to be in the lib folder, which has all the functions ready to go but the index doesn't setup express.

@jmszrm
Copy link
Copy Markdown
Author

jmszrm commented Jul 31, 2020

This is just a library, so every user can create their own express service and use these library functions. It's more efficient than making express functions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants