Skip to content

Add support for many more entity events #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for many more entity events #234

wants to merge 1 commit into from

Conversation

00-kat
Copy link
Collaborator

@00-kat 00-kat commented May 10, 2025 •
edited
Loading

And a few other things:

  • Add full stops.
  • Reorder some of them.
  • Lower-case entity kinds (e.g. Issue, Pull Request) to match the UI (though as far as I can tell the canonical spelling is upper-case; not sure why the UI differs).

Not sure if I should keep or remove the hack comments, I consider them a hack but others may not.

Here are some links for testing the newly added ones, in a code block so that GitHub doesn't notify everyone about unrelated stuff:

ready_for_review: https://github.com/ghostty-org/discord-bot/pull/175#event-16529671127 https://github.com/ghostty-org/discord-bot/issues/176#event-16596899731
auto_merge_enabled: https://github.com/ghostty-org/ghostty/pull/5341#event-16053815030
auto_merge_disabled: https://github.com/ghostty-org/ghostty/pull/5341#event-16053899865
head_ref_deleted: https://github.com/ghostty-org/ghostty/pull/5341#event-16053900676
head_ref_restored: https://github.com/Pix-xiP/remake/pull/2#event-13989779969
head_ref_force_pushed: https://github.com/ghostty-org/ghostty/pull/5650#event-16271684386 https://github.com/ghostty-org/discord-bot/pull/175#event-16529067881
automatic_base_change_succeeded: https://github.com/ghostty-org/discord-bot/pull/154#event-16440303050
convert_to_draft: https://github.com/ghostty-org/discord-bot/pull/175#event-16555527337
converted_to_discussion: https://github.com/ghostty-org/ghostty/issues/601#event-14492268323
parent_issue_added: https://github.com/ghostty-org/ghostty/issues/6709#event-16762188684
sub_issue_added: https://github.com/ghostty-org/ghostty/issues/5255#event-16762188659
pinned: https://github.com/ghostty-org/ghostty/issues/3558#event-15774572749
referenced: https://github.com/python/mypy/issues/6700#event-16524881873
demilestoned: https://github.com/ghostty-org/ghostty/issues/5491#event-16302256854
renamed: https://github.com/ghostty-org/ghostty/issues/5491#event-16304505401

@00-kat

This comment was marked as resolved.

Sign in to view
00-kat
00-kat commented May 10, 2025
View reviewed changes
app/components/github_integration/comments/fetching.py
if event.lock_reason:
body += f"\nReason: `{event.lock_reason or 'unspecified'}`"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right side of the or seems to be unreachable as far as I can tell, so I removed it; I may be wrong, however.

@00-kat 00-kat marked this pull request as draft May 10, 2025 03:07
@00-kat 00-kat marked this pull request as ready for review May 10, 2025 03:47
@00-kat 00-kat changed the title Add support for many more GitHub Issue events Add support for many more entity events May 10, 2025
@00-kat
Add support for many more entity events.
ff7d8e5 
Full stops were also added to every one, some items were reordered, and
entity kinds (e.g. Issue, Pull Request) were lower-cased to match the UI
(though as far as I can tell the canonical spelling is upper-case; not
sure why the UI differs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: github-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@00-kat