Skip to content

Conversation

@swsnr
Copy link
Contributor

@swsnr swsnr commented Dec 28, 2025

As far as I understand ghostty already integrates with systemd nowadays, and manages its own scopes/cgroups for the application and all tabs. As such, explicitly moving launching ghostty into a separate systemd scope from nautilus no longer seems necessary. In any case the scope created by the nautilus extension quickly goes away, suggesting that Ghostty moves its processes out of this scope, and the process tree looks just the same when spawning ghostty directly.

@swsnr swsnr requested a review from a team as a code owner December 28, 2025 14:53
@swsnr swsnr force-pushed the remove-systemd-from-nautilus-extension branch from d246fa2 to 3356545 Compare December 29, 2025 16:42
Copy link
Member

@tristan957 tristan957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @jcollie for review

As far as I understand ghostty integrates with systemd already nowadays,
and manages its own scopes/cgroups for tabs.  As such, explicitly moving
launching ghostty into a separate systemd scope from nautilus no longer
seems necessary.
@swsnr swsnr force-pushed the remove-systemd-from-nautilus-extension branch from 3356545 to 622d492 Compare December 29, 2025 21:36
@swsnr
Copy link
Contributor Author

swsnr commented Dec 29, 2025

@jcollie @tristan957 Thanks for the review. I pushed a small last-minute amend which removes the unused child variable and the __init__ method which was now effectively empty save for a parent constructor call.

I hope that's okay 🙂

@jcollie jcollie added this to the 1.3.0 milestone Dec 29, 2025
@jcollie jcollie merged commit 1fa6641 into ghostty-org:main Dec 29, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants