osc: parse the Kitty desktop notification protocol (OSC 99)#10467
Open
jcollie wants to merge 8 commits intoghostty-org:mainfrom
Open
osc: parse the Kitty desktop notification protocol (OSC 99)#10467jcollie wants to merge 8 commits intoghostty-org:mainfrom
jcollie wants to merge 8 commits intoghostty-org:mainfrom
Conversation
pluiedev
requested changes
Jan 27, 2026
Member
pluiedev
left a comment
pluiedev
left a comment
There was a problem hiding this comment.
First round of reviews, definitely not exhaustive since there's a ton to go through
jcollie
force-pushed
the
osc-kitty-notifications
branch
2 times, most recently
from
c726052 to
ffaf0c2
Compare
pluiedev
requested changes
Feb 1, 2026
jcollie
force-pushed
the
osc-kitty-notifications
branch
from
ffaf0c2 to
8ae4dd9
Compare
This includes only parsing of the OSC. You cannot use OSC 99 to send notifications. Uses lazy parsing of the metadata modelled on the new OSC 133 behavior.
* Add comments to Option keys to clarify their usage without having to refer to the spec online. * Use `indexOfNone` to simplify code.
* Fix typos. * Eliminate metadata parsing code duplication. * Improve documentation. * Ensure assert is comptime only. * Derive valid metadata characters from valid identifier characters.
jcollie
force-pushed
the
osc-kitty-notifications
branch
from
8ae4dd9 to
d412b3c
Compare
Reduce redundant code by sharing the metadata parsing code between the OSC 99 & OSC 5522 parsers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes only parsing of the OSC. You cannot (yet) use OSC 99 to send notifications. Uses lazy parsing of the metadata modelled on the new OSC 133 behavior.
Related to #5634