Skip to content

Add background image support for Metal #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Rohit-Bevinahally
Copy link
Contributor

@Rohit-Bevinahally Rohit-Bevinahally commented Jan 19, 2025

@Rohit-Bevinahally Rohit-Bevinahally marked this pull request as ready for review February 23, 2025 19:30
@Rohit-Bevinahally Rohit-Bevinahally requested a review from a team as a code owner February 23, 2025 19:30
@sagg0t
Copy link

sagg0t commented Mar 8, 2025

Hey @Rohit-Bevinahally, thank you for this PR, I can't wait to have it merged!
While using these changes in my local build, I noticed that the background image is separate for every split. I think many ghostty users (including me) would appreciate being able to have a single image for the whole window.

What's you opinion on this? Thanks again for the PR!

P.S. also noticed that the image doesn't cover vertical padding
image
image

@jcollie
Copy link
Member

jcollie commented Mar 8, 2025

While using these changes in my local build, I noticed that the background image is separate for every split. I think many ghostty users (including me) would appreciate being able to have a single image for the whole window.

This is because we don't have a renderer layer (Metal or OpenGL) that covers the entire window, only each individual surface. Adding that would require major surgery in how rendering is implemented and out-of-scope for this PR, and not something to be attempted without some in-depth discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants