core/gtk/glfw: open urls using an apprt action instead of doing it directly #5988
+223
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan957
approved these changes
Feb 25, 2025
|
Did you see https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.OpenURI.html? Seems like we should use that and then fallback to xdg-open. |
mitchellh
requested changes
Feb 25, 2025
jcollie
force-pushed
the
apprt-action-open-url
branch
from
20f4b88 to
4dde6f4
Compare
That looks interesting but I'd rather take that on in a follow-up PR after this is merged. |
jcollie
force-pushed
the
apprt-action-open-url
branch
2 times, most recently
from
d339ac3 to
0a69243
Compare
jcollie
force-pushed
the
apprt-action-open-url
branch
from
0a69243 to
70af7a1
Compare
jcollie
force-pushed
the
apprt-action-open-url
branch
from
70af7a1 to
7e852df
Compare
…rectly Partial implementation of ghostty-org#5256 This implements the core changes necessary to open urls using an apprt action rather than doing it directly from the core. Implements the open_url action in the GTK and GLFW apprts. Note that this should not be merged until a macOS-savvy developer can add an implementation of the open_url action for the macOS apprt.
jcollie
force-pushed
the
apprt-action-open-url
branch
from
7e852df to
aa8e7f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #5256
This implements the core changes necessary to open urls using an apprt action rather than doing it directly from the core.
Implements the open_url action in the GTK and GLFW apprts.
Note that this should not be merged until a macOS-savvy developer can add an implementation of the open_url action for the macOS apprt.