Add Hebrew Translations #6758
Add Hebrew Translations #6758
Conversation
|
We need at least one more speaker to help review these before they can be merged. Do you volunteer to maintain these translations as well? |
|
Yes, I volunteer to maintain these :) I'm using Ghostty daily so I'll be able to keep up and push updates quickly. I spotted a few other Hebrew speakers in Discord, hopefully some might be able to review the translations quickly. |
|
I'm a native speaker, but take these comments with a grain of salt as I haven't done software translations before and I use English on my devices so I'm not sure what users except and what would be the most consistent will other apps. I wish it was possible to have gendered translations because both e.g. "השאר/י" and "להשאיר" are less readable than a conditional "השאר"/"השארי", and translation systems like https://projectfluent.org/ can handle them, but I don't even think a preference for this is supported in OSes at all... |
|
Not even Fluent can help here since systems literally don't have information of the gender of the user... 🤷♀️ |
Exactly why I went with "השאר/י". The two options are using the male form of the verb everywhere ("השאר"), or the better option in my opinion, like it is now, using both and letting the user read it as they prefer with "השאר/י" :) |
|
We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait. @slsrepo I've added you to the localization team, can you rebase and fix this PR? |
|
Thanks Mitchell |
slsrepo
force-pushed
the
main
branch
2 times, most recently
from
80ca8da to
6641e2a
Compare
|
Looks like there are some missing translations in the file still. I'm happy to clean up the rest but I can't do the translation work. 😄 |
|
Working on that right now😅 |
|
@mitchellh All of the tests except for zig-fmt passed, so I think it's ready |
Pull request to add Hebrew translations, as discussed in the Discord.