gtk: add "remember choice" toggle for clipboard confirmation dialog #6783
Conversation
pluiedev
force-pushed
the
push-vwyvuxqlnmyu
branch
from
afb1fe5 to
5a574d3
Compare
Fuzzy matched strings are really annoying to pick out and remove for later. We should just leave strings untranslated until localizers get around to them, instead of letting gettext's (fairly naïve) algorithm to do that for us. No translation is better than a bad guesswork translation.
pluiedev
force-pushed
the
push-vwyvuxqlnmyu
branch
from
5a574d3 to
ea6f216
Compare
|
Should the text say something about the choice being remembered for the session? |
|
I also left a comment at #6763 (comment) |
|
The problem is that "session" is a very nebulous term, even more so in other languages (trying to express it in Chinese actually almost drove me insane). I think just implying that it only has an effect for this split, and that it will be reset after reloading the config, has pretty much the same effect. |
|
Implementing it per surface is very easy and I think could serve as an initial implementation. Per process would be a lot more complicated but perhaps still doable — out of scope for this PR though IMO |
|
I guess I'm confused about what session even means. Is it per ghostty instance or per surface? Referring to the original discussion |
The current PR is per-surface instance correct? So 5 tabs with 2 splits each you could potentially be asked 10 times. So anytime you create a new surface you'd be asked again. Also, I believe that if you reload your config you'd reset all that to default so you'd be asked again, even for surfaces where you'd already been asked. Mainly we just need to be clear with the documentation. Maybe there's a way to add a little "?" button that would explain in more detail than would fit in the confirmation dialog. |
Implements #6763 (not backporting to the 1.2 version since I'm way too lazy)