Skip to content

Add sv_SE Swedish locale #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

designbyadrian
Copy link

Po files added for Swedish.

No amendments for the macOS version due to localisation on macOS being in progress, according to Ghostty devs.

Copy link
Contributor

@Aaron-212 Aaron-212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't translated strings be placed in the msgstr?

Copy link
Member

@hqnna hqnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations are supposed to be put into the msgstr field, the msgid field should contain the original.

@pluiedev pluiedev added the translations Translations of the Ghostty app label Mar 20, 2025
@designbyadrian
Copy link
Author

Translations are supposed to be put into the msgstr field, the msgid field should contain the original.

That was embarrassing! I have understood the requirement and updated affected files.

@hqnna
Copy link
Member

hqnna commented Mar 21, 2025

That was embarrassing! I have understood the requirement and updated affected files.

Thanks! Can you rebase your branch so the conflict in src/os/i18n.zig is fixed?

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:18
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:73
msgid "Clear"
msgstr "Rensa"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

Suggested change
msgstr "Rensa"
msgstr "Töm"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but it should be noted Ptyxis uses "Rensa"


#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:85
msgid "Terminal Inspector"
msgstr "Terminalinspektören"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Terminalinspektören"
msgstr "Terminalinspektör"

Copy link

@jbergstroem jbergstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked how certain expressions were used in Terminal.app using the Swedish locale.


#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:89
msgid "Config"
msgstr "Konfiguration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted this debate also happened when we were doing Norwegian translations and came to the conclusion that Konfiguration fits better than Installningar due to the fact the original string is “Config” / “Configuration” as compared to “Settings” which I believe Terminal.app uses.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, no need to discuss it twice.

msgid ""
"⚠️ You're running a debug build of Ghostty! Performance will be degraded."
msgstr ""
"⚠️ Du kör en felsökningsversion av Ghostty! Prestanda kommer att försämras."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"⚠️ Du kör en felsökningsversion av Ghostty! Prestanda kommer att försämras."
"⚠️ Du använder en felsökningsversion av Ghostty! Prestanda kommer att försämras."


#: src/apprt/gtk/Window.zig:681
msgid "Reloaded the configuration"
msgstr "Laddade om konfigurationen"
Copy link

@jbergstroem jbergstroem Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Laddade om konfigurationen"
msgstr "Uppdaterade konfigurationen"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree on this one. "Uppdaterade" sounds like you wrote to the config, which is not the case here, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean... it depends on whether one interprets "updating" as updating the config file or the internal config state of the app. I personally would just avoid that word in order to stop that confusion from even occurring

Copy link

@jbergstroem jbergstroem Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Uppdaterade" sounds like you wrote to the config

Good point. I just find "Laddade om" confusing as well. That said, there seems to be consensus around it so I rest my case: https://en.m.wiktionary.org/wiki/ladda_om#Swedish


#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:89
msgid "Config"
msgstr "Konfiguration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted this debate also happened when we were doing Norwegian translations and came to the conclusion that Konfiguration fits better than Installningar due to the fact the original string is “Config” / “Configuration” as compared to “Settings” which I believe Terminal.app uses.


#: src/apprt/gtk/ui/1.5/ccw-paste.blp:6
msgid "Warning: Potentially Unsafe Paste"
msgstr "Varning: Potentiellt osäker infogning"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever heard infogning as a translation for "paste". "Klistra in" tends to be the used one, no?

Suggested change
msgstr "Varning: Potentiellt osäker infogning"
msgstr "Varning: Potentiellt osäker inklistring"


#: src/apprt/gtk/Window.zig:681
msgid "Reloaded the configuration"
msgstr "Laddade om konfigurationen"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree on this one. "Uppdaterade" sounds like you wrote to the config, which is not the case here, right?


#: src/apprt/gtk/CloseDialog.zig:96
msgid "All terminal sessions will be terminated."
msgstr "Alla terminalsessioner kommer att avslutas."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "Alla terminalsessioner kommer att avslutas."
msgstr "Alla terminalsessioner kommer avslutas."

Definitely a point of contention, but "att" is often an unnecessary word. This article is behind a paywall, but covers it nicely: Språktidningen

The feedback on this one covers quite a few unnecessary "att"s in this translation file

@mitchellh
Copy link
Contributor

We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait.

It looks like this one requires more consensus to merge as well as a group of volunteers to join the sv_SE localization team.

@designbyadrian, @cupofjoakim, @jbergstroem any volunteers to help bring this over the finish line and continue getting pinged for strings changes? Looking for at least two.

@Uzaaft
Copy link
Contributor

Uzaaft commented Apr 12, 2025

We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait.

It looks like this one requires more consensus to merge as well as a group of volunteers to join the sv_SE localization team.

@designbyadrian, @cupofjoakim, @jbergstroem any volunteers to help bring this over the finish line and continue getting pinged for strings changes? Looking for at least two.

I`m gonna ping @marijagjorgjieva as well, due to the PR that was opened. Feel free to throw your hat into the ring :)

"att kommandon kan utföras."

#: src/apprt/gtk/Window.zig:199
msgid "View Open Tabs"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main Menu?


#: src/apprt/gtk/CloseDialog.zig:90
msgid "Close Split?"
msgstr "Vill du stänga uppdelat fönster?"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it sound like the whole window with its splits will close. But I am unsure what else to say. "Uppdelning"? "Delning"? For reference, GNOME Builder has splits and Swedish translations and uses a combination of the words "ram" and "sida". Not sure that works here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Det uppdelade fönstret"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue remains. "Det uppdelade fönstret" is still referring to the window as a whole: "fönstret" is the subject. But the window contains tabs and splits, and this action only closes the split. So maybe "Stäng uppdelning?" is best?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like that suggestion @majjejjam – using "Uppdelning" as a noun that directly corresponds to "Split" makes a lot of sense to me and essentially reflects the original translation well.


#: src/apprt/gtk/CloseDialog.zig:98
msgid "All terminal sessions in this tab will be terminated."
msgstr "Alla terminalsessioner på den här fliken kommer att avslutas."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "i denna flik" to be consistent?


#: src/apprt/gtk/Surface.zig:1128
msgid "Copied to clipboard"
msgstr "Sparat i urklipp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, Ptyxis uses "Kopierat till urklipp"

Copy link

@jbergstroem jbergstroem Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed; "save" hints at storing permanently.

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:33
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:45
msgid "Change Title…"
msgstr "Ändra titel…"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, Ptyxis uses "Ställ in titel…"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this. Alternatively "Uppdatera"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO "Ändra" reads better. This is definitely subjective though.

#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:18
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:73
msgid "Clear"
msgstr "Rensa"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but it should be noted Ptyxis uses "Rensa"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations of the Ghostty app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants