-
Notifications
You must be signed in to change notification settings - Fork 787
Add sv_SE Swedish locale #6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add sv_SE Swedish locale #6837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't translated strings be placed in the msgstr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translations are supposed to be put into the msgstr
field, the msgid
field should contain the original.
That was embarrassing! I have understood the requirement and updated affected files. |
Thanks! Can you rebase your branch so the conflict in |
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:18 | ||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:73 | ||
msgid "Clear" | ||
msgstr "Rensa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps:
msgstr "Rensa" | |
msgstr "Töm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, but it should be noted Ptyxis uses "Rensa"
|
||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:85 | ||
msgid "Terminal Inspector" | ||
msgstr "Terminalinspektören" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Terminalinspektören" | |
msgstr "Terminalinspektör" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked how certain expressions were used in Terminal.app using the Swedish locale.
|
||
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:89 | ||
msgid "Config" | ||
msgstr "Konfiguration" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted this debate also happened when we were doing Norwegian translations and came to the conclusion that Konfiguration fits better than Installningar due to the fact the original string is “Config” / “Configuration” as compared to “Settings” which I believe Terminal.app uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, no need to discuss it twice.
msgid "" | ||
"⚠️ You're running a debug build of Ghostty! Performance will be degraded." | ||
msgstr "" | ||
"⚠️ Du kör en felsökningsversion av Ghostty! Prestanda kommer att försämras." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"⚠️ Du kör en felsökningsversion av Ghostty! Prestanda kommer att försämras." | |
"⚠️ Du använder en felsökningsversion av Ghostty! Prestanda kommer att försämras." |
|
||
#: src/apprt/gtk/Window.zig:681 | ||
msgid "Reloaded the configuration" | ||
msgstr "Laddade om konfigurationen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Laddade om konfigurationen" | |
msgstr "Uppdaterade konfigurationen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree on this one. "Uppdaterade" sounds like you wrote to the config, which is not the case here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean... it depends on whether one interprets "updating" as updating the config file or the internal config state of the app. I personally would just avoid that word in order to stop that confusion from even occurring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Uppdaterade" sounds like you wrote to the config
Good point. I just find "Laddade om" confusing as well. That said, there seems to be consensus around it so I rest my case: https://en.m.wiktionary.org/wiki/ladda_om#Swedish
|
||
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:89 | ||
msgid "Config" | ||
msgstr "Konfiguration" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted this debate also happened when we were doing Norwegian translations and came to the conclusion that Konfiguration fits better than Installningar due to the fact the original string is “Config” / “Configuration” as compared to “Settings” which I believe Terminal.app uses.
|
||
#: src/apprt/gtk/ui/1.5/ccw-paste.blp:6 | ||
msgid "Warning: Potentially Unsafe Paste" | ||
msgstr "Varning: Potentiellt osäker infogning" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I've ever heard infogning
as a translation for "paste". "Klistra in" tends to be the used one, no?
msgstr "Varning: Potentiellt osäker infogning" | |
msgstr "Varning: Potentiellt osäker inklistring" |
|
||
#: src/apprt/gtk/Window.zig:681 | ||
msgid "Reloaded the configuration" | ||
msgstr "Laddade om konfigurationen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree on this one. "Uppdaterade" sounds like you wrote to the config, which is not the case here, right?
|
||
#: src/apprt/gtk/CloseDialog.zig:96 | ||
msgid "All terminal sessions will be terminated." | ||
msgstr "Alla terminalsessioner kommer att avslutas." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Alla terminalsessioner kommer att avslutas." | |
msgstr "Alla terminalsessioner kommer avslutas." |
Definitely a point of contention, but "att" is often an unnecessary word. This article is behind a paywall, but covers it nicely: Språktidningen
The feedback on this one covers quite a few unnecessary "att"s in this translation file
We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait. It looks like this one requires more consensus to merge as well as a group of volunteers to join the sv_SE localization team. @designbyadrian, @cupofjoakim, @jbergstroem any volunteers to help bring this over the finish line and continue getting pinged for strings changes? Looking for at least two. |
I`m gonna ping @marijagjorgjieva as well, due to the PR that was opened. Feel free to throw your hat into the ring :) |
"att kommandon kan utföras." | ||
|
||
#: src/apprt/gtk/Window.zig:199 | ||
msgid "View Open Tabs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main Menu?
|
||
#: src/apprt/gtk/CloseDialog.zig:90 | ||
msgid "Close Split?" | ||
msgstr "Vill du stänga uppdelat fönster?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it sound like the whole window with its splits will close. But I am unsure what else to say. "Uppdelning"? "Delning"? For reference, GNOME Builder has splits and Swedish translations and uses a combination of the words "ram" and "sida". Not sure that works here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Det uppdelade fönstret"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue remains. "Det uppdelade fönstret" is still referring to the window as a whole: "fönstret" is the subject. But the window contains tabs and splits, and this action only closes the split. So maybe "Stäng uppdelning?" is best?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like that suggestion @majjejjam – using "Uppdelning" as a noun that directly corresponds to "Split" makes a lot of sense to me and essentially reflects the original translation well.
|
||
#: src/apprt/gtk/CloseDialog.zig:98 | ||
msgid "All terminal sessions in this tab will be terminated." | ||
msgstr "Alla terminalsessioner på den här fliken kommer att avslutas." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "i denna flik" to be consistent?
|
||
#: src/apprt/gtk/Surface.zig:1128 | ||
msgid "Copied to clipboard" | ||
msgstr "Sparat i urklipp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, Ptyxis uses "Kopierat till urklipp"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed; "save" hints at storing permanently.
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:33 | ||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:45 | ||
msgid "Change Title…" | ||
msgstr "Ändra titel…" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, Ptyxis uses "Ställ in titel…"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this. Alternatively "Uppdatera"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO "Ändra" reads better. This is definitely subjective though.
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:18 | ||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:73 | ||
msgid "Clear" | ||
msgstr "Rensa" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, but it should be noted Ptyxis uses "Rensa"
Po files added for Swedish.
No amendments for the macOS version due to localisation on macOS being in progress, according to Ghostty devs.