Skip to content

font: use regular JB Mono with dedicated Symbol font #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mitchellh
Copy link
Contributor

Fixes #7069

I'm not sure if this will have follow-on negative effects. In my day to day usage everything looks fine but its hard to really know. I think our best chance is to merge this and see what feedback we get. I know for sure positively that it does two things:

  1. Fixes the small symbols noted in Default embedded Deno symbol is too small #7069.
  2. Makes our binary size smaller since we no longer have unnecessary symbols embedded in our stylized fonts.

Fixes #7069

I'm not sure if this will have follow-on negative effects. In my day to
day usage everything looks fine but its hard to really know. I think our
best chance is to merge this and see what feedback we get. I know for
sure positively that it does two things:

  1. Fixes the small symbols noted in #7069.
  2. Makes our binary size smaller since we no longer have unnecessary
     symbols embedded in our stylized fonts.
@mitchellh mitchellh requested a review from a team as a code owner April 15, 2025 16:24
@qwerasd205
Copy link
Member

This has negative effects on symbols that need to be stretched to certain sizes for alignment purposes. I'll check later to remember which ones specifically, but it's for that reason that I held off on making this change until I implemented the nerd font patcher sizing rules in to our code

@mitchellh
Copy link
Contributor Author

I'll check later to remember which ones specifically, but it's for that reason that I held off on making this change until I implemented the nerd font patcher sizing rules in to our code

Okay, that's good enough reason for me to drop this for now. I'll add this context to the original issue and we can look back at it with a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default embedded Deno symbol is too small
2 participants