-
Notifications
You must be signed in to change notification settings - Fork 1.2k
macOS: Add GhosttyUITests (Drafting to save some ci checks) #9185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bo2themax
wants to merge
18
commits into
ghostty-org:main
Choose a base branch
from
bo2themax:support/ui-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf60ed9 to
940a7d1
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
940a7d1 to
959e8be
Compare
ed7fb63 to
bdeb9d0
Compare
73bf269 to
ef37282
Compare
10989db to
a5e2b98
Compare
Co-authored-by: Copilot <[email protected]>
a5e2b98 to
ced36e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
I was trying to add a few UI test cases for. In order to do this, I need a way frommacOS-titlebar-style[Already in this PR]GhosttyKitto load a temporary configuration without messing around with users'.Changes
ghostty_config_load_fileusing the existingloadFilexcbeautifyto format test&build errorsCouldn't find a way to do this in
GhosttyXcodebuild, if you have a better approach please let me know!GhosttyTitlebarTabsUITests(Titlebar Tabs #2349) andGhosttyThemeTests(macOS: fix theme reloading #9360)NOTE
Running UI tests on the runner could be very slow and I couldn't find a way to guarantee success, so I made these only runnable by manually testing in Xcode.
Better to squash this🤪