Skip to content

Conversation

@bo2themax
Copy link
Member

@bo2themax bo2themax commented Oct 13, 2025

Background

I was trying to add a few UI test cases for macOS-titlebar-style[Already in this PR]. In order to do this, I need a way from GhosttyKit to load a temporary configuration without messing around with users'.

Changes

  • Add ghostty_config_load_file using the existing loadFile
  • Use xcbeautify to format test&build errors
    Couldn't find a way to do this in GhosttyXcodebuild, if you have a better approach please let me know!
  • Add GhosttyUITests target and test cases for GhosttyTitlebarTabsUITests(Titlebar Tabs #2349) and GhosttyThemeTests(macOS: fix theme reloading #9360)

NOTE

Running UI tests on the runner could be very slow and I couldn't find a way to guarantee success, so I made these only runnable by manually testing in Xcode.

Better to squash this🤪

Some of the test cases could fail when testing all the cases together; a rerun would succeed.

@bo2themax bo2themax marked this pull request as ready for review October 13, 2025 14:38
@bo2themax bo2themax requested a review from a team as a code owner October 13, 2025 14:38
@bo2themax bo2themax marked this pull request as draft October 13, 2025 14:44
@bo2themax bo2themax marked this pull request as ready for review October 13, 2025 15:11
@bo2themax bo2themax force-pushed the support/ui-test branch 5 times, most recently from bf60ed9 to 940a7d1 Compare October 16, 2025 22:29
@mitchellh

This comment was marked as off-topic.

@bo2themax

This comment was marked as off-topic.

@bo2themax bo2themax changed the title macOS: Add GhosttyUITests macOS: Add GhosttyUITests [TESTING CI] Oct 27, 2025
@bo2themax bo2themax force-pushed the support/ui-test branch 3 times, most recently from ed7fb63 to bdeb9d0 Compare October 28, 2025 08:30
@bo2themax bo2themax changed the title macOS: Add GhosttyUITests [TESTING CI] macOS: Add GhosttyUITests Oct 28, 2025
@bo2themax bo2themax requested a review from Copilot October 28, 2025 09:34

This comment was marked as outdated.

This comment was marked as outdated.

@bo2themax bo2themax force-pushed the support/ui-test branch 2 times, most recently from 10989db to a5e2b98 Compare October 30, 2025 15:57
@bo2themax bo2themax marked this pull request as draft November 2, 2025 20:40
@bo2themax bo2themax changed the title macOS: Add GhosttyUITests macOS: Add GhosttyUITests (Drafting to save some ci checks) Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants