Skip to content

Conversation

@jcollie
Copy link
Member

@jcollie jcollie commented Oct 14, 2025

No description provided.

Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this style (lots of underscores).

And I want to keep Bytes dumb and not be aware of things like "osc" or "kv". I explicitly want downstream to handle this.

I think you're poking at some use case here, its not clear to me, but I don't think this API is the right direction.

@jcollie
Copy link
Member Author

jcollie commented Oct 14, 2025

Cleaned up the underscores and moved all of the alphabet generation downstream. I'm looking at improvements to the OSC parser, but I wanted to benchmark against a wider variety of OSC sequences as performance of the OSC parser varies depending on the OSC being parsed. While adding the generation of other OSC sequences I found it helpful to have this more flexible interface to the Bytes generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants