terminal: add osc8 tag handling for HTML formatter #9415
+296
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
requested changes
Oct 30, 2025
src/terminal/formatter.zig
Outdated
|
|
||
| /// Write a string with HTML escaping. Used for escaping href attributes | ||
| /// and other HTML attribute values. | ||
| fn writeHtmlEscaped( |
There was a problem hiding this comment.
We should already have this helper somewhere, writeCodepoint I think. Should be reused.
There was a problem hiding this comment.
Oops! Should be good now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTML page formatter can now track hyperlink state so tags open and close when the OSC 8 data changes. Also added a new
writeHtmlEscapedhelper to keep generated markup safe.Originally written with Copilot, revised by hand.