macOS: allow to pop surface into a new tab #9457
Open
+210
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the detach helpers and surface snapshots. These APIs are consumed by the command palette and context menu wiring that lands in the following commit.
Wire the new detach helpers into the context menu and command palette, document the UI affordances, and wrap the detach/tab creation flow in a single undo grouping.
|
Looks great to me in general!👍🏻 Still smaller ux things to be confirmed |
mitchellh
requested changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1525 #9100 #9430, form what I understood the repo guidelines this should be enough to put out a PR.
TLDR: When macOS tab contains 2+ surfaces we allow to pop active surface into a new native tab.
Note
PR made with help from Codex!
Changes
DetachedSurfaceis probably the biggest conceptual change introduced here, it allows to represent the split operation and revert it later via undo stack.Tests
Ran macOS build from Xcode project on M4, see videos of the scenarios below
Right click and command palette integration
Screen.Recording.2025-10-31.at.1.34.23.PM.mp4
Undo support
Screen.Recording.2025-11-02.at.2.07.00.PM.mov