gtk: Change tab title #9904
Open
gtk: Change tab title #9904
+154
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
requested changes
Dec 14, 2025
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Thanks, parts of this look great and others not so much. I think we should be able to rename SurfaceTitleDialog to TitleDialog and reuse that with differing copy depending on the mode, rather than introducing a whole new dialog.
The actual core tab stuff looks fine though.
Author
|
Thx for the review!. I refactored into a single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9880.
2025-12-14.06-50-31.mp4
Note
Used AI to get to explain to me some of the APIs and functionality between
windowsandtabsand their connections. But the code itself, I implemented everything, just used it for help with explaining some thingsIf you feel like reading more:
I feel there is a lot of duplication now with the
prompt surface titlefunctionality. For the dialog creation, i basically copied-pasted thesurface_title_dialog, and some of thetitleOverrideand theTabDialogSetfunctionality is identical to that of theprompt_surface_titleI would think about abstracting it out, but first I think Id be nice to think what the maintainers think about this approach before doing anything else.