hide mouse after idle time based on mouse-hide-after config
#9937
+109
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
requested changes
Dec 17, 2025
Contributor
mitchellh
left a comment
mitchellh
left a comment
There was a problem hiding this comment.
Thanks, overall very clean, just one major question.
src/Surface.zig
Outdated
|
|
||
| /// Hide the mouse if `mouse-hide-after` is configured and the mouse has been | ||
| /// idle (no movement) for at least that duration. | ||
| pub fn maybeHideMouseAfterIdle(self: *Surface) void { |
Contributor
There was a problem hiding this comment.
Do we need this core stuff at all? I think it might be cleaner to just implement this 100% in the apprt.
Contributor
Author
|
@mitchellh Thanks for the review! I completely agree and have made the requested changes. hope this aligns with what you expected. |
bo2themax
requested changes
Dec 23, 2025
Member
bo2themax
left a comment
bo2themax
left a comment
There was a problem hiding this comment.
Looks good on macOS, only a small suggestion
| return v; | ||
| } | ||
|
|
||
| var mouseHideAfter: UInt { |
Member
There was a problem hiding this comment.
Using Duration is better, like undoTimeout down below
pluiedev
reviewed
Dec 23, 2025
Member
pluiedev
left a comment
pluiedev
left a comment
There was a problem hiding this comment.
Looks good overall on the GTK side, just one question
src/apprt/gtk/class/surface.zig
Outdated
| priv.cursor_pos = pos; | ||
|
|
||
| // Track mouse movement time for `mouse-hide-after`. | ||
| priv.last_mouse_move_time = std.time.Instant.now() catch null; |
Member
There was a problem hiding this comment.
Is this ever used? I don't think it is, right?
bo2themax
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #8385
Implement a new
mouse-hide-afterduration config that hides the cursor after a period of no mouse movement while keeping it hidden during typing. The core tracks the last mouse move inSurface.cursorPosCallbackand usesSurface.maybeHideMouseAfterIdle()to decide when to callhideMouse(). On macOS this is driven by a per-surface NSTimer inSurfaceView_AppKit, and on GTK by a per-surface GLib timeout inclass/surface.zig, both reset on mouse movement. macOS usesNSCursor.setHiddenUntilMouseMovesto integrate with the native cursor API, while GTK relies on the existingmouse_visibilityaction wired through the core surface.Tests on macos and linux